|
DDASToys for NSCLDAQ
6.2-000
|
(ASC 1/20/23): Awkward way to process the sample and exclude types. Can we return a vector of uint16_t or whatever the CDataSourceFactory wants? Item type codes are uint32_t so why are we mixing between signed/unsigned ints and different bits?
(ASC 3/10/23): To support different NSCLDAQ data formats, we need to read the version string from the args and create an appropriate ring item factory. The ROOT converter should be independent of the data format since we can hand it CPhysicsEventItems from the correct format type.
(ASC 10/15/24): Probably a project-wide TODO... only the public and Qt signaling interfaces need to be exposed here. I suspect that any helper functions can be make static, which may greatly simplify the class and make compilation easier.
(ASC 10/16/24): Probably another project-wide TODO... avoid constructor initializations which use the new keyword. Can use smart ptrs (preferred?) or simply initialize in the constructor body with the initialization list for all pointer membvers as nullptr. Hopefully improves safety e.g., an exception or other error in the constructor body will (hopefully!) ensure deletion of created objetcs which may not happen if new'd in init list.